Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ttl duration when ttl is None #1624

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix ttl duration when ttl is None #1624

merged 1 commit into from
Jun 7, 2021
+1 −0

Conversation

MattDelac
Copy link
Collaborator

What this PR does / why we need it:
Fix ttl_duration when TTL is None
image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Fix ttl_duration when ttl is None

@MattDelac MattDelac requested review from achals, tsotnet, woop and a team as code owners June 7, 2021 12:51
@feast-ci-bot
Copy link
Collaborator

Hi @MattDelac. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MattDelac
Copy link
Collaborator Author

/kind bug

@MattDelac MattDelac changed the title Fix ttl duration Fix ttl duration when ttl is None Jun 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #1624 (e7ff05e) into master (7877828) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   83.64%   83.55%   -0.09%     
==========================================
  Files          67       67              
  Lines        5814     5815       +1     
==========================================
- Hits         4863     4859       -4     
- Misses        951      956       +5
Flag Coverage Δ
integrationtests 83.55% <100.00%> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 87.87% <100.00%> (+0.12%) ⬆️
sdk/python/tests/conftest.py 83.87% <0.00%> (-16.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7877828...e7ff05e. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MattDelac, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 7, 2021

Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005

@MattDelac
Copy link
Collaborator Author

MattDelac commented Jun 7, 2021 •
edited
Loading

Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005

Will do

@MattDelac
Copy link
Collaborator Author

Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005

That did not help for now

image

@woop
Copy link
Member

woop commented Jun 7, 2021

I think we have to wait for it to be resolved here: codecov/codecov-action#330

For the time being I will turn off failure in CI

Fix ttl_duration when None
e7ff05e 
Signed-off-by: Matt Delacour <[email protected]>
@woop
Copy link
Member

woop commented Jun 7, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit e712782 into feast-dev:master Jun 7, 2021
@MattDelac MattDelac deleted the fix_ttl_duration branch June 7, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@achals achals Awaiting requested review from achals

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@woop woop

Labels
approved kind/bug lgtm ok-to-test release-note size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MattDelac @feast-ci-bot @codecov-commenter @woop @achals